URL: https://github.com/freeipa/freeipa/pull/271
Title: #271: Remove hard dependency on ipaplatform from ipapython, ipalib and 
ipaclient

tiran commented:
"""
@jcholast I prefer small patches, that change just one aspect and are easily 
reviewable in a couple of minutes. The PR touches the entire code base. With 
600 additions, more than 700 removals and 316 QC high-severity issues, it is 
going to take a week to merge it. Merge conflicts are already cumulating, too.

You have already split up your PR in a bunch of commits. It looks like most to 
all commits are unrelated and don't depend on each other. Basically your PR is 
an epic with a bunch of independent improvements. How about use the iterative 
approach and create a PR for each commit?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/271#issuecomment-262920843
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to