Ingo van Lil <[EMAIL PROTECTED]> schrieb:
A patch for libfreeipmi is attached. Admittedly, checking out the PEF
section isn't any more successful with the patch than it used to be,
but at least the error message changed from "unsupported command" to
"expression failed".
OK, got it: The "parameter revision" field was missing in all the
tmpl_cmd_get_pef_configuration_parameters_*_rs definitions in
ipmi-pef-and-alerting-cmds.c. Patch attached.
Cheers,
Ingo
Index: libfreeipmi/src/ipmi-pef-and-alerting-cmds.c
===================================================================
RCS file: /sources/freeipmi/freeipmi/libfreeipmi/src/ipmi-pef-and-alerting-cmds.c,v
retrieving revision 1.13
diff -u -r1.13 ipmi-pef-and-alerting-cmds.c
--- libfreeipmi/src/ipmi-pef-and-alerting-cmds.c 14 Apr 2006 04:20:06 -0000 1.13
+++ libfreeipmi/src/ipmi-pef-and-alerting-cmds.c 4 Sep 2006 14:59:25 -0000
@@ -242,6 +242,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "pef", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "pef_event_messages", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "pef_startup_delay", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
@@ -254,6 +256,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "alert_action", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "power_down_action", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reset_action", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
@@ -268,6 +272,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "pef_startup_delay", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{0, "", 0}
};
@@ -276,6 +282,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "pef_alert_startup_delay", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{0, "", 0}
};
@@ -285,6 +293,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "number_of_event_filters", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{0, "", 0}
@@ -294,6 +304,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "filter_number", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{5, "filter_configuration.reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
@@ -335,6 +347,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "filter_number", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{5, "filter_configuration.reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
@@ -348,6 +362,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "number_of_alert_policy_entries", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{0, "", 0}
@@ -358,6 +374,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "number_of_alert_strings", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{0, "", 0}
@@ -367,6 +385,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "string_selector", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved2", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "filter_number", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
@@ -380,6 +400,8 @@
{
{8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "comp_code", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "present_revision", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+ {4, "oldest_revision_parameter", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{7, "string_selector", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
{8, "block_selector", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
_______________________________________________
Freeipmi-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/freeipmi-devel
