Albert Chu <[EMAIL PROTECTED]> schrieb:

Thanks Ingo.  Great catches.  I've checked all your changes in.

Found a few more bugs today:

- Several *_commit functions in bmc-sol-conf-section.c used to
  free the kv->value before actually parsing it, resulting in
  the actual parameter being set to 0.
- One of the fields in
  tmpl_cmd_set_pef_configuration_parameters_pef_startup_delay_rq
  was misnamed.
- The Power_Restore_Policy in the Misc section is now commented
  out if the BMC reports it as unknown.

Cheers,
Ingo
Index: bmc-config/src/bmc-misc-section.c
===================================================================
RCS file: /sources/freeipmi/freeipmi/bmc-config/src/bmc-misc-section.c,v
retrieving revision 1.10
diff -u -r1.10 bmc-misc-section.c
--- bmc-config/src/bmc-misc-section.c	9 Aug 2006 23:45:35 -0000	1.10
+++ bmc-config/src/bmc-misc-section.c	5 Sep 2006 14:09:07 -0000
@@ -96,7 +96,7 @@
   add_keyvalue (misc_section,
 		"Power_Restore_Policy",
 		"Possible values: Off_State_AC_Apply/Restore_State_AC_Apply/On_State_AC_Apply",
-                0,
+		BMC_CHECKOUT_KEY_COMMENTED_OUT_IF_VALUE_EMPTY,
 		power_restore_policy_checkout,
 		power_restore_policy_commit,
 		power_restore_policy_diff,
Index: bmc-config/src/bmc-sol-conf-section.c
===================================================================
RCS file: /sources/freeipmi/freeipmi/bmc-config/src/bmc-sol-conf-section.c,v
retrieving revision 1.11
diff -u -r1.11 bmc-sol-conf-section.c
--- bmc-config/src/bmc-sol-conf-section.c	9 Aug 2006 23:45:35 -0000	1.11
+++ bmc-config/src/bmc-sol-conf-section.c	5 Sep 2006 14:09:07 -0000
@@ -465,9 +465,6 @@
   if (ret != 0)
     return -1;
 
-  if (kv->value)
-    free (kv->value);
-
   interval = atoi (kv->value);
 
   return set_sol_character_accumulate_interval_and_send_threshold (args->dev,
@@ -569,9 +566,6 @@
   if (ret != 0)
     return -1;
 
-  if (kv->value)
-    free (kv->value);
-
   threshold = atoi (kv->value);
 
   return set_sol_character_accumulate_interval_and_send_threshold (args->dev,
@@ -673,9 +667,6 @@
   if (ret != 0)
     return -1;
 
-  if (kv->value)
-    free (kv->value);
-
   count = atoi (kv->value);
 
   return set_sol_sol_retry (args->dev,
@@ -782,9 +773,6 @@
   if (ret != 0)
     return -1;
 
-  if (kv->value)
-    free (kv->value);
-
   interval = atoi (kv->value);
 
   return set_sol_sol_retry (args->dev,
Index: libfreeipmi/src/ipmi-pef-and-alerting-cmds.c
===================================================================
RCS file: /sources/freeipmi/freeipmi/libfreeipmi/src/ipmi-pef-and-alerting-cmds.c,v
retrieving revision 1.14
diff -u -r1.14 ipmi-pef-and-alerting-cmds.c
--- libfreeipmi/src/ipmi-pef-and-alerting-cmds.c	5 Sep 2006 05:34:51 -0000	1.14
+++ libfreeipmi/src/ipmi-pef-and-alerting-cmds.c	5 Sep 2006 14:09:08 -0000
@@ -124,7 +124,7 @@
     {8, "cmd", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
     {7, "parameter_selector", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
     {1, "reserved", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
-    {8, "startup_delay", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
+    {8, "pef_startup_delay", FIID_FIELD_REQUIRED | FIID_FIELD_LENGTH_FIXED},
     {0, "", 0}
   };
 
_______________________________________________
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/freeipmi-devel

Reply via email to