"L.C. (Laurentiu C. Badea)" <[EMAIL PROTECTED]> wrote:
3) "authorize"/"authorization" for restrictions on validated users. 4) "post-auth" to allocate IPs and add other attributes to the reply
There's no reason to separate those two sections. They're exactly the same thing.
I believe they are functionally different, and that (4) is dependent on (3), so that is a good reason for separation. I think another good test for groupings like this is, if the items in one group can be reordered or not. If the (3+4) group passes this test, then it could safely be considered as one unit, otherwise it might make sense to break it down.
5) "post-request" for logging and cleanup. Ideally this would be called after the reply has been sent (hence the name) because there is no point to make the client wait while we prepare the logs.
That's not a bad idea, but I'm not sure where it would be useful. Do you have examples?
It's mainly a performance improvement. Under high load, to maintain the fastest response time, the extra time taken to (write log file + detail + sql) becomes significant, and since we already have all the response data, we might as well send it before we do that.
This opens up the possibility of moving the logging overhead into a separate thread with lower priority, that does not have to be synchronized to the request handlers any more. This should give you a performance boost at the cost of not getting real-time logs under load.
I would also call "instantiate" -> "preload" because according to the summary it loads the specified modules before any others.
Sure, it doesn't matter too much.
As for the implementing the actual change, perhaps planned obsolescence and config file versions can help if you decide to go ahead with it. Or maybe a radically different approach (XML ?).
XML is impossible for the average human to edit.
It is indeed very verbose but has certain advantages. It has a very well defined structure, easy recognizable syntax and is very extensible. A pain to edit manually, which is a pity, although there should be XML editors out there to make it easier.
Alan DeKok.
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
-- L.C. (Laurentiu C. Badea)
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
