Hi,


> These look like they might be real problems. Sorry fror the lack of
> further investigation, I'm doing this while @ work :)

NP; please don't bother with investigating those, as they're well-known
issues (at least to me- YMMV ;-)

> cfsml.pl: In function `_cfsml_write_state_t':
> cfsml.pl:428: warning: passing arg 2 of `write_any_widget' from
> incompatible pointer type
> cfsml.pl: In function `_cfsml_read_state_t':
> cfsml.pl:643: warning: passing arg 2 of `read_any_widget' from
> incompatible pointer type
> cfsml.pl: In function `_cfsml_write_gfxw_port_t':
> cfsml.pl:418: warning: passing arg 2 of `write_any_widget' from
> incompatible pointer type
> cfsml.pl: In function `_cfsml_read_gfxw_port_t':
> cfsml.pl:643: warning: passing arg 2 of `read_any_widget' from
> incompatible pointer type

This is generated code. Fixing it would mean fixing the code generator to
do rather specific workarounds, and I don't think that's worth it.

> kgraphics.c: In function `_k_redraw_box':
> kgraphics.c:283: warning: overflow in implicit constant conversion

Explicit warning- this function was not ported to the new gfx subsystem (I
don't think it is needed, though this makes me wonder whether anything was
broken by the issue). If no issues pop up until 0.3.2 wrt this, we can
remove the warning and the commented code (unless I missed something...)

> kgraphics.c: At top level:
> kgraphics.c:1237: warning: `nsrect_clip' declared inline after being
> called

Fixed. Thanks!

> scriptdebug.c: In function `c_visible_map':
> scriptdebug.c:1018: warning: overflow in implicit constant conversion

Missing functionality- explicit warning (we still don't support showing 
priority or control maps while games are running).

> scriptdebug.c: In function `script_debug':
> scriptdebug.c:2349: warning: overflow in implicit constant conversion

Explicit warning again, this time for the missing on-screen console.

> sci_pic_0.c: In function `_gfxr_auxbuf_propagate_changes':
> sci_pic_0.c:286: warning: left shift count >= width of type
> sci_pic_0.c:287: warning: left shift count >= width of type

Checked for during run-time (actually, -O1 or better will optimize out
those shift operations, as sizeof(long) is used there).
Only affects 32 bit platforms anyway.

> sci_pic_0.c: In function `gfxr_draw_pic0':
> sci_pic_0.c:2050: warning: overflow in implicit constant conversion

Explicit warning, but this one's obsolete. I'll remove it.


Thanks again!

llap,
 Christoph


Reply via email to