Ok, so we need a new approach...

1. Bundle (known good?) snapshots of LPCNet into FreeDV and either
statically link, or at least make the library "private", i.e.:
/usr/lib{,64}/freedv on RPM based systems.

We can either copy it in, which I hate for one reason, or use git
submodules which I hate for another:

With copying it it, we're adding a lot of duplicate data into git, which I
don't like.

With git submodules, github doesn't handle this very gracefully. You have
to upload your own archives to include them and you can't turn off the "on
the fly" archives and they do NOT include the submodules.

What's nice about them is that you can point to a specific commit (or a
branch or tag probably) so the version you "get" in the submodule is fixed.

Then we could update the CMake config of LCPNet to be smart enough to know
if it's a stand alone build, or being called by FreeDV's cmake and act
appropriately.

2. Use the github "on-the-fly" archives for Freedv but upload "known good"
archives of LPCNet and the module data with the release. Simplifies stuff
for us a lot, but it will take more work for the end user.

Thoughts?

Thanks,
Richard
KF5OIM
_______________________________________________
Freetel-codec2 mailing list
Freetel-codec2@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freetel-codec2

Reply via email to