On Thu, Apr 19, 2018 at 1:05 AM, Waldek Hebisch <[email protected]> wrote: > oldk1331 wrote: >> >> On Mon, Apr 16, 2018 at 9:15 PM, Waldek Hebisch >> <[email protected]> wrote: >> > AFAICS several patches make code more complicated, I am not >> > shure if we want such changes. >> >> Yes, some patches make code longer, but not necessarily more >> complicated. I use the most natural algorithm according to FR's >> Rep: most functions takes 2 sorted list as arguments, then the >> function body loops over them, doing computations (on exponents >> and flags) and deduplicating items with same factors. >> >> You will see that after my patches, 'exquo', '=', 'gcd', '*' >> all have similar structures. Also, this explicit loop is required >> to achieve O(N) complexity instead of O(N*log(N)) or worse. > > Well, in actual use I typically see number of factors smaller than 10. > Do you have any application in mind that requires large number of > factors?
I don't have any applications in mind other than artificial ones. Still, users may call Factored directly with big arguments. >> Can I merge all these patches? I would prefer to merge them >> each as a individual patch. > > What do you really want? I wrote about batching the patches, > now you want them separately? > > As I wrote 0001 can go in and should go as separate patch. 0002 and > 0003 are really single patch, splitting them is artificial and > confusing. > -- > Waldek Hebisch > What I meant is to commit them in sequence, so that commit history is clear. 0002 and 0003 should be merged, 0008 and 0010 can be merged, the rest should be separate commits so that the commit history is atomic and clear. -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
