On Thu, Mar 18, 2021 at 07:49:49PM +0800, Qian Yun wrote:
> This is the change I made to get the macOS dmg working.
> Not very elegant, but I wonder if there is a better way?
>
> Comments are welcome. And macOS users can try/test the binary
> at https://github.com/oldk1331/fricas/actions/runs/664218153
>
> - Qian
>
> https://github.com/fricas/fricas/commit/ed1f43ad1a7be891a6bbb050b055e2ff7f9f3ab8.patch
>
> diff --git a/Makefile.in b/Makefile.in
> index f50f0bde3..17af45595 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -133,9 +133,11 @@
> echo exec_prefix='"$${FRICAS_PREFIX:-$(exec_prefix)}"' \
> >> '${COMMAND}'.tmp
> if test "$(fricas_lib)" != "$(libdir)" ; then \
> - echo \
> - FRICAS='"$${exec_prefix}/$(fricas_lib)/fricas/target/$(target)"' \
> - >> '${COMMAND}'.tmp ; \
> + if test $(uname -s) != "Darwin" ; then \
^^
$$(uname -s)
> + echo
> FRICAS='"$${exec_prefix}/$(fricas_lib)/fricas/target/$(target)"' >>
> '${COMMAND}'.tmp ; \
> + else \
> + echo FRICAS='"`dirname
> $$0`/../$(fricas_lib)/fricas/target/$(target)"' >> '${COMMAND}'.tmp ; \
> + fi \
> else \
> echo FRICAS='"$(libdir)/fricas/target/$(target)"' \
> >> '${COMMAND}'.tmp ; \
Hi Qian, I wonder why you wanted the 'dirname $$0' part? It breaks
internal 'fricas' script for its intended uses, in particular
it causes problem reported by Gregory Vanuxem, that is failure
of 'efricas'. AFAICS you intended 'dirname $$0' part to be
used only on Mac OS, but you need to double '$' for this.
Doubling '$' fixes problem on other systems, but there remain
question what 'dirname $$0' solves? I think that even on
Mac OS it does not work for internal 'fricas' script.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/20210503192631.GA19657%40math.uni.wroc.pl.
