On 6/23/24 17:45, Waldek Hebisch wrote:
I have small comments to other parts. On page 1 in section
Authors we should add Qian Yun.
OK, that is new commit S then.
The 'update list of required latex
packages' commit leaves 'mleftright' in INSTALL (IIUC it is no
longer needed).
Thank you for looking so closely. I'll correct patch M.
On 6/23/24 16:01, Qian Yun wrote:
> In your commit A, I think it's better to use "b*x" instead of
> "bx" in the first diff block, and there's a missing right
> parenthesis in "log(cot(x)".
Thank's Qian. I'll correct patch A.
> Commit G should be merged with commit B.
I think you did it correctly.
> But I still think target "viewports" should not depend on
> target "stamp-book-viewports"
Well, maybe a good point. The initial reason why I included it into
viewport was that the target "viewport" exists, because if xvfb is not
existing, the pictures are not created for HyperDoc.
You are in a sense right that target doc in src/doc/Makefile is not
build by a top-level make, i.e. the book is only built on explicit call
to make book in src/doc. It should be come as no surprise if there will
be many windows popping up during "make doc" in case xvfb is not
available. Now, thinking about this issue, maybe you are right and
stamp-book-viewports can be removed from viewports. Please check whether
the building of the book viewports is triggered by "make doc". The
pictures (even in a parallel) build must be available before latex is
started. I faintly remember that some pictures weren't yet available
during the latex run. So make-book must be dependend on
stamp-book-viewports.
> I'm doing final testings, if everything is OK, I'll
> commit B/C/G, D, E/F, H/I with Changelogs and attributions to you.
> You can handle the rest commits as you see fit.
Basically OK, but I still have a few comments to B/C/G.
> (I've included one small change that move "subspace(vp)" of section
> 10.1 to psXtc.
Sorry, I feel that this is not correct. Execute the commands from the
generated .input file. \psXtc is supposed to produce a .ps file.
You have not given a name for such a file in the third argument of
\psXtc. Does the generated write(...) command connected to \psXtc
actually work without error?
Fortunately, it is \spadcommand{sp := subspace(vp)\bound{d5}\free{d1}}
and not \spadgraph, because otherwise the viewport vp would have been
closed before that subspace(vp) command is executed, which would produce
an error, I guess.
> I also added target "${PS_FILES_PS}" to "stamp-book-pics" to make
> commit B build.
Seem to look OK.
> I've updated the squashed and rebased branch to
> https://github.com/oldk1331/fricas/commits/new-ps-book-final/
>
> If there are no further comments, I'd like to merge those 4
> long overdue commits.
I am still rechecking your squashed stuff, but I am too tired right now.
Hopefully I can manage tomorrow night.
Ralf
--
You received this message because you are subscribed to the Google Groups "FriCAS -
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to fricas-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/5ab8b5b4-24a7-4a2f-9f38-be0827b47bd3%40hemmecke.de.
