Hi Qian,

On 6/23/24 16:01, Qian Yun wrote:
 > Commit G should be merged with commit B.

I think you did it correctly.

 > But I still think target "viewports" should not depend on
 > target "stamp-book-viewports"

OK, let's try without that dependency. The book-pdf target depends on the pictures, so everything is fine.

 > I'm doing final testings, if everything is OK, I'll
 > commit B/C/G, D, E/F, H/I with Changelogs and attributions to you.
 > You can handle the rest commits as you see fit.

OK under the conditions below.

 > (I've included one small change that move "subspace(vp)" of section
 > 10.1 to psXtc.

You should not include this part as I mentioned in my last mail.

 > I also added target "${PS_FILES_PS}" to "stamp-book-pics" to make
 > commit B build.

OK.

 > I've updated the squashed and rebased branch to
 > https://github.com/oldk1331/fricas/commits/new-ps-book-final/

You should change "tmp/vp-input" in Makefile.in back to "tmp/vp-*.input".

-# - Run the tmp/vp-input files through fricas (target ${HTEX_VIEWPORTS_STAMP}) +# - Run the tmp/vp-*.input files through fricas (target ${HTEX_VIEWPORTS_STAMP})

 > If there are no further comments, I'd like to merge those 4
 > long overdue commits.

You have my OK.

Thank you, Qian.

I'll then prepare the remaining changes.

Ralf

--
You received this message because you are subscribed to the Google Groups "FriCAS - 
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to fricas-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/fricas-devel/f2707299-169a-43f4-b5b5-506dea2a2b65%40hemmecke.org.

Reply via email to