On Sun, 5 May 2013, Franck Villaume wrote:
> > Missing period at the end of this one?
>
> Yes. Missing period.
Do we want them? Then put it as rule that messages should be
written as “whole sentences”, which implies them. I’ve used
“taglines” often, which would begin lowercase and not end
with a period, but I can see the benefit of using whole sentences.
But then, shouldn’t we start uppercase after the colon?
> > > $error_msg .= _('Error:').' '.$acr->getErrorMessage();
> > For this case, and many like it, it would probably be better to use a
> > sprintf() call:
> >
> > $error_msg .= sprintf(_('Error: %s'),$acr->getErrorMessage());
+1
$acr->getErrorMessage() would probably return a whole sentence
starting with an uppercase letter, so this would even be consistent.
Otherwise, agreed on all points.
bye,
//mirabilos
--
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-314
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Boris Esser, Sebastian Mancke
_______________________________________________
Fusionforge-general mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general
