On 07/03/2008, Jesús Guerrero <[EMAIL PROTECTED]> wrote: > On Thu, 06 Mar 2008 20:34:03 -0500 > Dan Espen <[EMAIL PROTECTED]> wrote: > > > =?ISO-8859-1?Q?Jes=FAs?= Guerrero <[EMAIL PROTECTED]> writes: > > > On Fri, 7 Mar 2008 00:44:09 +0100 > > > Jes=FAs Guerrero <[EMAIL PROTECTED]> wrote: > > > > > > Conditionals patch revised and attached. > > > > > > Is it valid? Does it lack something? > > > > > > My idea is to shorten the list of available patches as much as we can > by=20 > > > including those that are evidently clean, useful and harmless upstream. > > > That way, we can ease the process for the rest of the patches. > > > > Except for not updating test cases (which almost no one is doing), > > it looks clean and reasonable to me. > > > I saw that file and plan to update it. I just need to watch into it > to understand the logic of the thing. Feel free to give any advice if > you feel that there's something relevant that I should know. > > For now, I have a preliminary versions with that file included. Attached.
I was the original author of this patch to add HasTitle and HasBorders - it was then augmented by someone else, I forget whom. To be honest, there's all *manner* of different tests one could do here, and this patch is by no means representative enough of them. Although if more conditionals are to be added in this way, the list would get rather long, and an alternative approach might need to be sought after. -- Thomas Adam
