On Fri, Mar 07, 2008 at 02:26:49AM +0100, Jesús Guerrero wrote:
> On Fri, 7 Mar 2008 00:44:09 +0100
> Jesús Guerrero <[EMAIL PROTECTED]> wrote:
>
> Conditionals patch revised and attached.
>
> Is it valid? Does it lack something?
I don't want to add patches like this anymore. Fvwm should have
generic parsing of styles, states and conditions to that *all*
stlye names are state names and condition names at the same time.
I don't think any of this should be included in 2.6.
> My idea is to shorten the list of available patches as much as we can by
> including those that are evidently clean, useful and harmless upstream.
> That way, we can ease the process for the rest of the patches.
>
> --
> Jesús Guerrero <[EMAIL PROTECTED]>
> </section>
> diff -U5 -r fvwm/fvwm/conditional.c fvwm/fvwm/conditional.c
> --- fvwm/fvwm/conditional.c 2007-10-06 11:17:09.000000000 +0200
> +++ fvwm/fvwm/conditional.c 2008-03-07 01:10:54.000000000 +0100
> @@ -598,10 +598,40 @@
> else if (StrEquals(cond,"HasHandles"))
> {
> SET_HAS_HANDLES(mask, on);
> SETM_HAS_HANDLES(mask, 1);
> }
> + else if (StrEquals(cond, "HasTitle"))
> + {
> + SET_HAS_TITLE(mask, on);
> + SETM_HAS_TITLE(mask, 1);
This should probably check for the actual title heigt too.
> + }
> + else if (StrEquals(cond, "HasBorders"))
> + {
> + SET_HAS_NO_BORDER(mask, !on);
> + SETM_HAS_NO_BORDER(mask, 1);
This should probably check for the actual border heigt too.
> + }
> + else if (StrEquals(cond, "TitleAtBottom"))
> + {
> + SET_TITLE_DIR(mask, DIR_S);
> + SETM_TITLE_DIR(mask, 1);
> + }
> + else if (StrEquals(cond, "TitleAtTop"))
> + {
> + SET_TITLE_DIR(mask, DIR_N);
> + SETM_TITLE_DIR(mask, 1);
> + }
> + else if (StrEquals(cond, "TitleAtLeft"))
> + {
> + SET_TITLE_DIR(mask, DIR_W);
> + SETM_TITLE_DIR(mask, 1);
> + }
> + else if (StrEquals(cond, "TitleAtRight"))
> + {
> + SET_TITLE_DIR(mask, DIR_E);
> + SETM_TITLE_DIR(mask, 1);
> + }
> else if (StrEquals(cond,"Iconifiable"))
> {
> SET_IS_UNICONIFIABLE(mask, !on);
> SETM_IS_UNICONIFIABLE(mask, 1);
> }
Ciao
Dominik ^_^ ^_^
P.S.: Ich lese E-Post nur zweimal täglich.
--
Dominik Vogt
