On Tue, Mar 11, 2008 at 04:03:37PM +0100, Dominik Vogt wrote:
[snip]
> > +static void parse_vertical_margins_line(
> > + char *args, signed char *top, signed char *bottom,
> > + signed char top_default, signed char bottom_default)
> > +{
> > + int val[2];
> > +
> > + if (GetIntegerArguments(args, NULL, val, 2) != 2 ||
> > + val[0] < MIN_VERTICAL_SPACING || val[0] > MAX_VERTICAL_SPACING ||
> > + val[1] < MIN_VERTICAL_SPACING || val[1] > MAX_VERTICAL_SPACING)
>
> MAX_VERTICAL_SPACING and MIN_VERTICAL_SPACING are not defined in
> the patch. Anyway, MIN_VERTICAL_SPACING should be just 0 and
> MAX_VERTICAL_SPACING the same value that is used for
> MAX_MENU_BORDER_WIDTH.
Ah, these values are already defined. It's better to use a new
constant MAX_MENU_MARGIN (in libs/defaults.h).
@Victor: I wanted to say that it might make sense to have a
style similar to ItemFormat for the vertical layout too.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
