On Thu, Jul 26, 2001 at 05:43:39PM +0700, Dmitry Yu. Bolkhovityanov wrote:
Content-Description: Mail message body
> Hi!
>
> That's part 1 of XineramaSupport v2 merger. It contains
> libs/XineramaSupport.[ch] as drop-in replacements. Next part will be
> configure script, followed by modules.
>
> The only change required is to fvwm/menus.c -- to use
> XiSuppClipToScreenAt() instead of XiSuppClipToScreen() (the first of them
> appeared in XiSupp after february version).
>
> Dominik, I have a question/correction regarding your changes to XiSupp.c.
> The XiSuppDisable() was intended as a mechanism to hard-disable Xinerama,
> while XiSuppSetState() -- to turn it on/off on the fly. As I understood,
> you changed XiSuppSetState() to be internal call, while
> XiSupp{Enable,Disable} are used as previously XiSuppSetState(). Am I right?
I just took the time to start merging the patch. Please try to
write code keeping this in mind:
- Code is written with 80 characters per line, a basic
indentation width of 2.
- Always compile the code with and without your ifdefs. Remove
all warnings (compile with 'make CFLAGS="-Wall -Werror -g").
- Please keep in mind that that fvwm is controlled and configured
by configuration commands, not by environment variables. It's
not necessary to make features configurable via the
environment. (I'll remove the corresponding code).
- Please try to use one of the formatting styles that is used in
the fvwm code (indentation style). Try not to put commands on
the same line as a condition.
- RandR support will certainly be no part of 2.4.1. You should
really try to split the patches you made on your disk into
several patch files that can be applied individually.
One question about the XiParseGeometry function: I don't
understand why is does so many things. It really shouldn't do
more than just parsing the geometry string like XParseGeometry
does and use the same signature. I'll comment out all the extra
stuff for now.
Bye
Dominik ^_^ ^_^
--
Dominik Vogt, email: [EMAIL PROTECTED]
LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen
fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
