On Tue, Aug 28, 2018 at 05:40:02PM +0200, Stefan Blachmann wrote: > Well, I think this points to an off-by-one bug in Firefox's SessionStore.jsm > > A quick peek into the source made me stumble over this: > > Bottom and right coordinates are calculated there this way: bottom = > top + height > this will result in an off-by-1 bottom coordinate... > ...shouldn't it be bottom = top + height - 1 ? > > Please look at the restoreDimensions() function, line 4137+ > in particular lines 4165 and 4180 > > (Link: > https://hg.mozilla.org/mozilla-central/file/190b827aaa2b/browser/components/sessionstore/SessionStore.jsm > ) > > What do you think? > Do you think a bug report at Mozilla is justified?
I don't see any problem with that logic. The "bottom" coordinate is not used as the name suggests. Unless aHeight is larger than the screen height wehn the function is called, its value is used unchanged in the aWindow.resizeTo() call. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
