Hi,
On Monday 04 February 2008, Dominik Vogt wrote:
> Should be fixed with my latest commit. I think the X error should
> be gone too. Can you try it and look if the X error reappears,
> pease?
I have attached a patch which checks image != NULL before calling
XDestroyImage(image). After this, FVWM does not crash, but my
FvwmButtons-based panel does (see log attached).
--
Regards,
Roman
Index: fvwm/colorset.c
===================================================================
RCS file: /home/cvs/fvwm/fvwm/fvwm/colorset.c,v
retrieving revision 1.55
diff -u -p -r1.55 colorset.c
--- fvwm/colorset.c 3 Feb 2008 23:12:19 -0000 1.55
+++ fvwm/colorset.c 4 Feb 2008 16:15:32 -0000
@@ -1191,7 +1191,10 @@ void parse_colorset(int n, char *line)
ERR, "parse_colorset",
"error reading root background");
}
- XDestroyImage(image);
+ if (image != None)
+ {
+ XDestroyImage(image);
+ }
if (mask_image != None)
{
XDestroyImage(mask_image);
GNU gdb 6.7.1-debian
Copyright (C) 2007 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "i486-linux-gnu"...
Using host libthread_db library "/lib/i686/cmov/libthread_db.so.1".
(gdb) run
Starting program: /home/busa/apps/fvwm-cvs/bin/fvwm --replace
[Thread debugging using libthread_db enabled]
/bin/sh: sh -c 'find /home/busa/.fvwm/var -type f -print0 | xargs -0 rm': No such file or directory
[fvwm.1][ReadDecorFace]: <<ERROR>> unknown button face flag 'Raised,' -- line: -- Raised, HiddenHandles
/bin/sh: sh -c 'find /home/busa/.fvwm/var -type f -print0 | xargs -0 rm': No such file or directory
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.1][CMD_EdgeResistance]: <<DEPRECATED>> The command EdgeResistance with three arguments is obsolete. Please use the following commands instead:
[fvwm.1][]: <<DEPRECATED>> EdgeResistance 1000
[fvwm.1][]: <<DEPRECATED>> Style * EdgeMoveDelay 1000
[fvwm.1][]: <<DEPRECATED>> Style * EdgeMoveResistance 20
[fvwm.1][CMD_SnapGrid]: <<DEPRECATED>> The command SnapGrid is obsolete. Please use the following command instead:
[fvwm.1][]: <<DEPRECATED>> Style * SnapGrid 5 5
[fvwm.1][CMD_SnapAttraction]: <<DEPRECATED>> The command SnapAttraction is obsolete. Please use the following command instead:
[fvwm.1][]: <<DEPRECATED>> Style * SnapAttraction 5
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.0][ReadDecorFace]: <<ERROR>> unknown button face flag 'Raised,' -- line: -- Raised, HiddenHandles
[fvwm.0][CMD_EdgeResistance]: <<DEPRECATED>> The command EdgeResistance with three arguments is obsolete. Please use the following commands instead:
[fvwm.0][]: <<DEPRECATED>> EdgeResistance 1000
[fvwm.0][]: <<DEPRECATED>> Style * EdgeMoveDelay 1000
[fvwm.0][]: <<DEPRECATED>> Style * EdgeMoveResistance 20
[fvwm.0][CMD_SnapGrid]: <<DEPRECATED>> The command SnapGrid is obsolete. Please use the following command instead:
[fvwm.0][]: <<DEPRECATED>> Style * SnapGrid 5 5
[fvwm.0][CMD_SnapAttraction]: <<DEPRECATED>> The command SnapAttraction is obsolete. Please use the following command instead:
[fvwm.0][]: <<DEPRECATED>> Style * SnapAttraction 5
[fvwm.1][Echo]: 32
[fvwm.1][Echo]: 0
[fvwm.1][Echo]: 0
[fvwm.1][Echo]: 0
[fvwm.1][parse_colorset]: <<ERROR>> error reading root background
[fvwm.1][parse_colorset]: <<ERROR>> error reading root background
[fvwm.0][Echo]: 32
[fvwm.0][Echo]: 0
[fvwm.0][Echo]: 0
[fvwm.0][Echo]: 0
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.0][FvwmErrorHandler]: <<ERROR>> *** internal error ***
[fvwm.0][FvwmErrorHandler]: <<ERROR>> Request 73, Error 8, EventType: 28
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.0][FvwmErrorHandler]: <<ERROR>> *** internal error ***
[fvwm.0][FvwmErrorHandler]: <<ERROR>> Request 73, Error 8, EventType: 28
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
ComboPanel: Cause of next X Error.
Error: 13 (BadGC (invalid GC parameter))
Major opcode of failed request: 70 (PolyFillRectangle)
Minor opcode of failed request: 0
Resource id of failed request: 0x3000020
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.0][parse_colorset]: <<ERROR>> error reading root background
[fvwm.1][parse_colorset]: <<ERROR>> error reading root background
[fvwm.1][parse_colorset]: <<ERROR>> error reading root background
