-- keith Pope <[email protected]> wrote
(on Thursday, 12 February 2009, 02:44 PM +0000):
> Talking of patches, I submitted one for
> http://framework.zend.com/issues/browse/ZF-4167 which is a patch for
> getting rid of Zend_Loader in the Db table classes. I would be
> interested in your view on this patch as you have been working on the
> autoloader stuff. Currently its just a quick proof of concept but I
> would be happy to do unit tests, docs once there is some feedback.
Well, while I'm working on autoloading additions, we won't switch over
to solely autoloading until 2.0, as it introduces a huge BC break.
In looking at your patch, there's a much simpler way to accomplish it:
if (!class_exists($this->_rowClass)) {
Zend_Loader::loadClass($this->_rowClass);
}
While this retains the dependency on Zend_Loader, it allows you to use
your own autoloader to check for the class first -- in particular, a
resource loader could intercept the call and load the class without
hitting Zend_Loader::loadClass().
> 2009/2/12 Matthew Weier O'Phinney <[email protected]>:
> > -- Colin Guthrie <[email protected]> wrote
> > (on Wednesday, 11 February 2009, 11:15 PM +0000):
> >> 'Twas brillig, and Benjamin Eberlei at 11/02/09 17:03 did gyre and gimble:
> >> > you should create an account at http://framework.zend.com/issues and file
> >> > issues against Zend_Db, put their alert level up based on what you think
> >> > is
> >> > necessary. Also make sure not to put all the things into one issue, but
> >> > split them up so that they are unique items to be worked at.
> >>
> >> ... and supply patches ;)
> >
> > That last statement cannot be emphasized nearly enough.
> >
> > Most issues that suggest changes merely for the sake of OO purity will
> > be ignored in favor of _real_ issues/feature requests. There's simply
> > very little, if any, benefit to investing the time to make the changes
> > in most cases.
> >
> > However, if you supply a _patch_ -- especially if it contains unit tests
> > for any functional changes -- we'll be much more likely to apply them
> > and accept the change.
> >
> > --
> > Matthew Weier O'Phinney
> > Software Architect | [email protected]
> > Zend Framework | http://framework.zend.com/
> >
>
>
>
> --
> ----------------------------------------------------------------------
> [MuTe]
> ----------------------------------------------------------------------
>
--
Matthew Weier O'Phinney
Software Architect | [email protected]
Zend Framework | http://framework.zend.com/
