On Thu, Dec 13, 2012 at 02:53:43PM +0100, Michael Hanselmann wrote: > 2012/12/12 Guido Trotter <ultrot...@google.com>: > > On Wed, Dec 12, 2012 at 2:28 AM, Iustin Pop <ius...@google.com> wrote: > >> I am very very unhappy with this patch. We have to do this, in order > >> to be compatible with the Python code and behaviour, but there's lots > >> of duplication; both the Python and the Haskell code will need to be > >> cleaned up and simplified (we don't need QFF_* at all). > >> > >> For now though, this implements QffTimestamp and associated code. > >> > >> Signed-off-by: Iustin Pop <ius...@google.com> > > > > What's QFF (sorry for not remembering) and why are we implementing > > instead of removing it, if we don't need it? > > I'd also be interested to know why we don't need it. QFF stands for > “query field flags” and they are used to define fields which needs > special treatment, e.g. for comparison (think of hostnames).
We need it right now, because of how queries are implemented. But, after reading the code, at least QFF_TIMESTAMP is a suboptimal idea that just increases code complexity. I haven't looked at QFF_HOSTNAME in depth, to be honest. After 2.7 is done, I plan to go through and try to remove QFF_*. iustin
