LGTM, since the discussion about removing QFF is going to happen later, anyway.
Thanks, Guido On Mon, Dec 17, 2012 at 3:30 AM, Iustin Pop <ius...@google.com> wrote: > On Wed, Dec 12, 2012 at 11:28:29AM +0100, Iustin Pop wrote: >> I am very very unhappy with this patch. We have to do this, in order >> to be compatible with the Python code and behaviour, but there's lots >> of duplication; both the Python and the Haskell code will need to be >> cleaned up and simplified (we don't need QFF_* at all). >> >> For now though, this implements QffTimestamp and associated code. >> >> Signed-off-by: Iustin Pop <ius...@google.com> >> --- > > ping. -- Guido Trotter Ganeti engineering Google Germany