On 14 May 2013 15:52, Thomas Thrainer <[email protected]> wrote: > LUNetwork* and associated helper functions are extracted to network.py. > > Signed-off-by: Thomas Thrainer <[email protected]> > --- > Makefile.am | 3 +- > lib/cmdlib/__init__.py | 714 +----------------------------------------------- > lib/cmdlib/common.py | 25 ++ > lib/cmdlib/network.py | 718 > +++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 749 insertions(+), 711 deletions(-) > create mode 100644 lib/cmdlib/network.py
In most of Ganeti code, helper functions precede their use in a file. In network.py you are putting helper functions at the end of the file. I think it would be better if we would be consistent on this regard. Rest LGTM, thanks. Bernardo
