On 16 May 2013 12:14, Bernardo Dal Seno <[email protected]> wrote:
> On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote:
>> LUNetwork* and associated helper functions are extracted to network.py.
>>
>> Signed-off-by: Thomas Thrainer <[email protected]>
>> ---
>> Makefile.am | 3 +-
>> lib/cmdlib/__init__.py | 714
>> +-----------------------------------------------
>> lib/cmdlib/common.py | 25 ++
>> lib/cmdlib/network.py | 718
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 749 insertions(+), 711 deletions(-)
>> create mode 100644 lib/cmdlib/network.py
>
> LGTM, thanks.
Not really, sorry. This breaks the ordering:
diff --git a/Makefile.am b/Makefile.am
index 35d1e5d..58b1869 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -311,7 +311,8 @@ cmdlib_PYTHON = \
lib/cmdlib/__init__.py \
lib/cmdlib/common.py \
lib/cmdlib/base.py \
- lib/cmdlib/tags.py
+ lib/cmdlib/tags.py \
+ lib/cmdlib/network.py
Rest still LGTM :-)
Bernardo
