On Wednesday 06 April 2011, Vladimir Vuksan wrote:
> I spoke to Bernard and we are considering doing a code freeze of the Web
> 2.0 UI. I'd like to release it by the end of month so that people can start
> using it.
>
> Thoughts ?

Excellent work!


I did some small modifications:
- remove config option $conf['show_cores'] (There is no code which will use 
it)
- link to the graph_all_periods.php at the grid overview (like at the cluster 
overview) 
- at graph_all_periods.php link the graphs to graph.php (like at the grid 
overview)




monitor-web-2.0$ svn diff
Index: conf_default.php.in
===================================================================
--- conf_default.php.in (revision 2570)
+++ conf_default.php.in (working copy)
@@ -121,11 +121,6 @@
 $conf['cpu_num_color']  = "FF0000";
 $conf['num_nodes_color'] = "00FF00";
 
-#
-# Display number of cores in LOAD report graph
-#
-$conf['show_cores'] = false;
-
 # Other colors
 $conf['jobstart_color'] = "ff3300";
 
Index: templates/default/meta_view.tpl
===================================================================
--- templates/default/meta_view.tpl     (revision 2570)
+++ templates/default/meta_view.tpl     (working copy)
@@ -45,21 +45,21 @@
 
 {if isset($source.self_summary_graphs)}
   <TD ALIGN="RIGHT" VALIGN="TOP">
-    <A HREF="./graph.php?{$source.graph_url}&amp;g=load_report&amp;z=large">
+    <A HREF="./graph_all_periods.php?
{$source.graph_url}&amp;g=load_report&amp;z=large">
       <IMG SRC="./graph.php?
{$source.graph_url}&amp;g=load_report&amp;z=medium"
            ALT="{$source.name} LOAD" BORDER="0">
     </A><BR>
-    <A HREF="./graph.php?{$source.graph_url}&amp;g=cpu_report&amp;z=large">
+    <A HREF="./graph_all_periods.php?
{$source.graph_url}&amp;g=cpu_report&amp;z=large">
       <IMG SRC="./graph.php?
{$source.graph_url}&amp;g=cpu_report&amp;z=medium"
            ALT="{$source.name} CPU" BORDER="0">
     </A>
   </TD>
   <TD VALIGN="TOP">
-    <A HREF="./graph.php?{$source.graph_url}&amp;g=mem_report&amp;z=large">
+    <A HREF="./graph_all_periods.php?
{$source.graph_url}&amp;g=mem_report&amp;z=large">
       <IMG SRC="./graph.php?
{$source.graph_url}&amp;g=mem_report&amp;z=medium"
            ALT="{$source.name} MEM" BORDER="0">
     </A><BR>
-    <A HREF="./graph.php?
{$source.graph_url}&amp;g=network_report&amp;z=large">
+    <A HREF="./graph_all_periods.php?
{$source.graph_url}&amp;g=network_report&amp;z=large">
       <IMG SRC="./graph.php?
{$source.graph_url}&amp;g=network_report&amp;z=medium"
            ALT="{$source.name} NETWORK" BORDER="0">
     </A>
Index: graph_all_periods.php
===================================================================
--- graph_all_periods.php       (revision 2570)
+++ graph_all_periods.php       (working copy)
@@ -78,7 +78,7 @@
   print '<div class="img_view">' .
   '<a href="./graph.php?r=' . $key . $query_string .'&csv=1"><img alt="Export 
to CSV" height=16 width=16 src="img/csv.png"></a> ' .
   '<a href="./graph.php?r=' . $key . $query_string .'&json=1"><img 
alt="Export to JSON" height=16 width=16 src="img/js.png"></a>' .
-  '<br /><img alt="Last ' . $key . '" src="graph.php?r=' . $key . '&z=' . 
$largesize . $query_string . '"></div>';
+  '<br /><a href="./graph.php?r=' . $key . '&z=' . $xlargesize . 
$query_string . '"><img alt="Last ' . $key . '" src="graph.php?r=' . 
$key . '&z=' . $largesize . $query_string . '"></a></div>';
 
 }
 // The div below needs to be added to clear float left since in aggregate 
view things



Markus
-- 
Markus Köberl
Graz University of Technology
Signal Processing and Speech Communication Laboratory
E-mail: markus.koeb...@tugraz.at

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to