On Mon, Oct 11, 2010 at 15:42, Bernard Li <[email protected]> wrote:
> Hi Jamie:
>
> On Sun, Oct 10, 2010 at 11:40 PM, Jamie Isaacs <[email protected]> wrote:
>
>> These PHP Notice/Warning errors are fixed in this patch against trunk r2347:
>> http://bugzilla.ganglia.info/cgi-bin/bugzilla/attachment.cgi?id=231
>
> Thanks -- any chance you could also make the patch backward compatible
> with the old format for specifying optional_graphs?
>
> $optional_graphs = array('packet');
>
> Jesse, any additional thoughts?
A few, but they are probably not backwards compatible, and will
require some thought/discussion.
IIRC, the current code requires that you list all optional graphs,
regardless of where they are used, in $optional_graphs. This amounts
to some annoying duplication, since you have change things in multiple
places to show the graphs: once in conf.php, and again in the
*_view.php file.
I'd *like* to be able to specify different metrics based on a
cluster/view classification. Essentially, something structurally like
this:
$optional_graphs = array(
"global" => array("nfs_traffic")
"global_host" => array("packet"),
"global_cluster" => array();
"meta" => array("packet", "job_queue"),
"Alpha_compute" => array(
cluster => array("packet", "sys_temperature", "!nfs_traffic"),
host => array("packet", "nfs_traffic"),
),
"Alpha_storage" => array(
"global" => array("storage"),
cluster => array("job_queue", "packet", "nerf_herders", "lustre"),
host => array("packet", "lustre", "!sys_temperature"),
),
)
A quick explanation:
* Globally--on all clusters, all relevant views (meta, cluster, host),
show the "nfs_traffic" graph. It is assumed that this graph makes
sense in all contexts...
* In all per-host views, show the "packet" graph (but not per-cluster
views).
* There is a concept of "global_cluster" graphs, but nothing is
defined. This should be considered valid, but a noop.
* For the meta view, show the custom reports for "packet" and
"job_queue" (in addition to the globally requested "nfs_traffic
graph)"
* For the "Alpha_compute" cluster, show the "packet" and
"sys_temperature" graphs, but do *not* show the globally defined
nfs_traffic graph.
* For a host within the Alpha_compute cluster, show "packet" and "nfs_traffic".
* The Alpha_Storage cluster is similar, but show the "storage" report
in the cluster and host views.
* For hosts in Alpha_storage, do *not* show "sys_temperature." Here,
this should be a noop,
since this report was not requested from a higher level (i.e.
globally, or cluster-wide.
but as I said, this requires more code. I'm also open to better ways
to do this.
> Thanks for bearing with us, we are pretty close to getting this
> checked in... :-)
I concur. Also, I do not think that my ramblings above should
delay/prevent these patches from being committed.
--
Jesse Becker
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Ganglia-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-general
