Hi Jamie:

On Fri, Oct 15, 2010 at 4:49 PM, Bernard Li <[email protected]> wrote:

> Actually, why don't you hold off on uploading another patch until
> after me and perhaps Jesse have time to fully test it, that case we
> will be able to give you better feedback so you don't have to go
> through this incremental patching business.

Sorry for the delayed response, here are some additional comments:

1) As previously mentioned, please make the old-style optional graphs
to show up in cluster_view only
2) For grid page, can you just tag the optional graph after the
default graphs for the grid?  The title of the graph only shows "Grid"
without the actual name of the grid.
3) For host page, it looks like even if you choose "false", the
optional graph still shows up -- probably an artifact for supporting
the old-style optional graphs -- also is it possible to have the graph
show up following the rest of the graphs on the right hand side
(instead of on the left hand side)?
4) Report an error if user specified a rrd file that does not exist
5) With the following in conf.php:

$optional_graphs = array('packet' => array('pkts_+', false, true, true));

It gave a bunch of error messages like:

[Tue Nov 02 15:01:12 2010] [error] [client 192.168.1.12] PHP Notice:
Undefined index:   in
/var/www/html/ganglia.trunk.vanilla/web/functions.php on line 219,
referer: 
http://server01/ganglia.trunk.vanilla/web/?m=load_one&r=hour&s=descending&hc=4&mc=2
[Tue Nov 02 15:01:12 2010] [error] [client 192.168.1.12] PHP Warning:
array_key_exists() [<a
href='function.array-key-exists'>function.array-key-exists</a>]: The
second argument should be either an array or an object in
/var/www/html/ganglia.trunk.vanilla/web/functions.php on line 219,
referer: 
http://server01/ganglia.trunk.vanilla/web/?m=load_one&r=hour&s=descending&hc=4&mc=2

Thanks,

Bernard

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ganglia-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-general

Reply via email to