I'm not sure if this is related but I finally put my DSO modules on git.
https://github.com/pdt256/gmond_python_modules

I noticed a problem in my "patch against trunk r2355 v2" for custom graphs
using "+" showing up on the cluster view...they don't show up at all :) I
will get a new patch created when I get a chance.

Also, I don't think the "+" or "*" options are even included in the
meta/grid view. I did not have a need for them yet but I can add that
feature if this custom graph patch will get accepted upstream.

Does any of this make sense?

--
Jamie Isaacs
[email protected]


On Fri, Nov 5, 2010 at 3:04 AM, Jamie Isaacs <[email protected]> wrote:

> Bernard,
>
> On Nov 2, 2010, at 5:04 PM, Bernard Li wrote:
>
> 1) As previously mentioned, please make the old-style optional graphs
> to show up in cluster_view only
>
> * Done
>
> 2) For grid page, can you just tag the optional graph after the
> default graphs for the grid?  The title of the graph only shows "Grid"
> without the actual name of the grid.
>
> * Done
>
> 3) For host page, it looks like even if you choose "false", the
> optional graph still shows up -- probably an artifact for supporting
> the old-style optional graphs -- also is it possible to have the graph
> show up following the rest of the graphs on the right hand side
> (instead of on the left hand side)?
>
> * Need feedback
>
>
> Are you sure you want all the custom optional graphs to show up in a single
> column on the right? I like having the optional graphs show up in the middle
> section so they can span multiple columns. I thought that is what that area
> was for? Let me know your thoughts.
>
>
> 4) Report an error if user specified a rrd file that does not exist
>
> * Need feedback
>
>
> If I have an optional MySQL report to be displayed on all hosts that have
> the corresponding required rrd file, then I don't want an error being thrown
> when I visit the host view for a host that doesn't have MySQL metrics. With
> that in mind, throwing errors doesn't make sense on the host view.
>
> The same goes for a cluster that only runs MySQL servers and one that runs
> web servers. I don't think throwing an error makes sense in this case
> either.
>
> I like the idea of handling errors in the optional graphs, but I'm not sure
> where we can fit them in. The whole reason I wrote this code was to avoid
> the pesky missing images I have seen in the past with my grids... and to
> support some more advanced graph reports with the + and *.
>
>
> 5) It gave a bunch of error messages...
>
> * Done
>
>
> #5 was a strange one to fix. The PHP Warning was being generated after
> processing the global variable $metrics in a foreach. Nothing was modified,
> but later in the find_limits() function the PHP Warning was being thrown. I
> solved the problem by setting $metrics to a local variable and then
> processing it in the foreach.
>
>
>
> I have a patch with the latest changes against trunk-2355 and 3.1.7 here:
> Custom Graph patch against trunk r2355 
> v2<http://bugzilla.ganglia.info/cgi-bin/bugzilla/attachment.cgi?id=248>
> Custom Graph patch against tag 3.1.7 
> v2<http://bugzilla.ganglia.info/cgi-bin/bugzilla/attachment.cgi?id=249>
>
> The 3.1.7 patch does not include #2 part 1. I could not figure out how to
> put the optional graphs under the default graphs for the grid within my time
> constraints. The template code was just too funky.
>
> --
> Jamie Isaacs
> [email protected]
>
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Ganglia-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-general

Reply via email to