https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71767

--- Comment #21 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #20)
> Created attachment 39661 [details]
> patchset cf 240230
> 
> 
> patchset rebased to 240230 - should apply cleanly.

As Dominique pointed out last night, g++.dg/abi/key2.C needs adjustment.

This is supposed to test that we emit the right sections for things that need
coalescing - which now only applies to older linkers.  So the fix here is to
make it test for correct output with a forced old linker.

We could add a new test to see that the non _coal,coalesced sections are
emitted for new linkers, but that's probably a moot point since many other
tests would fails (as per this PR).

---

diff --git a/gcc/testsuite/g++.dg/abi/key2.C b/gcc/testsuite/g++.dg/abi/key2.C
index 0d1347a..c79b3b2 100644
--- a/gcc/testsuite/g++.dg/abi/key2.C
+++ b/gcc/testsuite/g++.dg/abi/key2.C
@@ -2,6 +2,7 @@
 // PR darwin/25908

 // { dg-do compile { target *-*-darwin* } }
+// { dg-options "-mtarget-linker 85.2" }
 // { dg-final { scan-assembler ".globl __ZTV1f\\n      .weak_definition
__ZTV1f(\\n    .section __DATA,__const_coal,coalesced)?\\n     .align" } }
 // { dg-final { scan-assembler ".globl __ZTS1f\\n      .weak_definition
__ZTS1f\\n     .section __TEXT,__const_coal,coalesced" } }
 // { dg-final { scan-assembler ".globl __ZTI1f\\n      .weak_definition
__ZTI1f(\\n    .section __DATA,__const_coal,coalesced)?\\n     .align" } }

Reply via email to