https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104552

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=104794
                 CC|                            |iains at gcc dot gnu.org,
                   |                            |prathamesh3492 at gcc dot 
gnu.org,
                   |                            |rsandifo at gcc dot gnu.org

--- Comment #28 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Roland Illig from comment #9)
> From config/host-darwin.cc:
> > error ("PCH memory not available %m");
> 
> Looks like a missing ":" before "%m".

Iain Sandoe's string (22a98240)

(In reply to Roland Illig from comment #10)
> From aarch64-sve-builtins.cc:
> > error_at (location, "passing single vector %qT to argument %d"
> >           " of %qE, which expects a tuple of %d vectors",
> >           actual, argno + 1, fndecl, num_vectors);
> 
> "%d vectors" must use the correct plural form, for the benefit of Polish,
> Russian, Arabic and several more.

Richard Sandiford's string (624d0f07)

(In reply to Roland Illig from comment #11)
> From aarch64-sve-builtins.cc:
> > passing %qT to argument %d of %qE, which expects a scalar integer
> 
> "scalar integer" sounds redundant, this may be a copy-and-paste mistake from
> the message directly above, which says "scalar element".

Likewise.

(In reply to Roland Illig from comment #12)
> From aarch64-sve-builtins.cc:
> > "capture by copy of SVE type %qT"
> 
> This message should use the same grammar as the related ones, the word
> "cannot" is a useful indicator of the general error condition.

Same author, different commit (02a32ab4)

(In reply to Roland Illig from comment #13)
> From aarch64.cc:
> > invalid feature modifier %s
> 
> The %s must be %qs, like in the related messages.

Looks like Martin L was the last one to touch it (in 03a1a86b, which,
ironically, was a -Wformat-diag fix)

(In reply to Roland Illig from comment #14)
> From aarch64.cc:
> > "invalid name (%qs) in %<target(\"arch=\")%> pragma or attribute"
> 
> What is the point of having parentheses around %qs? That seems redundant to
> me.

Likewise.

(In reply to Roland Illig from comment #15)
> From aarch64.cc:
> > arch extension %<%s%>
> 
> Use the idiomatic %qs instead.

Prathamesh's string (145be5ef)

(In reply to Roland Illig from comment #16)
> From arm-builtins.cc:
> > "the range of count should be in 0 to 32;
> > please check the intrinsic %<_mm_rori_pi16%> in code"
> 
> Please double-check whether the "0 to 32" is a typo and should rather be "0
> to 16". That would match the "0 to 64" for _mm_rori_si64 a few lines further
> down.

I think this was covered by bug 104794

(taking a break again)

Reply via email to