https://gcc.gnu.org/g:b1f11b31bf105415f9a495d82366de8f3f571205

commit b1f11b31bf105415f9a495d82366de8f3f571205
Author: Jakub Jelinek <ja...@redhat.com>
Date:   Thu Feb 15 13:55:49 2024 +0100

    gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead
    
    On Fri, Feb 09, 2024 at 11:03:38AM +0100, Jakub Jelinek wrote:
    > On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.co...@embecosm.com wrote:
    > > This patch introduces one regression because generics are getting better
    > > understood over time. The code here used to apply generics with the same
    > > symbol from previous segments which was a bit of a hack with out limited
    > > inference variable support. The regression looks like it will be related
    > > to another issue which needs to default integer inference variables much
    > > more aggresivly to default integer.
    > >
    > > Fixes #2723
    > >     * rust/compile/issue-1773.rs: Moved to...
    > >     * rust/compile/issue-1773.rs.bak: ...here.
    >
    > Please don't use such suffixes in the testsuite.
    > Either delete the testcase, or xfail it somehow until the bug is fixed.
    
    To be precise, I have scripts to look for backup files in the tree (*~,
    *.bak, *.orig, *.rej etc.) and this stands in the way several times a day.
    
    Here is a fix for that in patch form, tested on x86_64-linux with
    make check-rust RUNTESTFLAGS='compile.exp=issue-1773.rs'
    
    2024-02-15  Jakub Jelinek  <ja...@redhat.com>
    
            * rust/compile/issue-1773.rs.bak: Rename to ...
            * rust/compile/issue-1773.rs: ... this.  Add dg-skip-if directive.

Diff:
---
 gcc/testsuite/rust/compile/{issue-1773.rs.bak => issue-1773.rs} | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/rust/compile/issue-1773.rs.bak 
b/gcc/testsuite/rust/compile/issue-1773.rs
similarity index 89%
rename from gcc/testsuite/rust/compile/issue-1773.rs.bak
rename to gcc/testsuite/rust/compile/issue-1773.rs
index a4542aea00b0..468497a4792e 100644
--- a/gcc/testsuite/rust/compile/issue-1773.rs.bak
+++ b/gcc/testsuite/rust/compile/issue-1773.rs
@@ -1,4 +1,5 @@
 #[lang = "sized"]
+// { dg-skip-if "" { *-*-* } }
 pub trait Sized {}
 
 trait Foo<T> {

Reply via email to