https://gcc.gnu.org/g:3621d2ac22b75b154c2964c0db84b58be427f3a8
commit r15-4964-g3621d2ac22b75b154c2964c0db84b58be427f3a8
Author: Andrew Pinski <quic_apin...@quicinc.com>
Date: Mon Nov 4 23:42:29 2024 -0800
c: gimplefe: Only allow an identifier before ? [PR117445]
Since r13-707-g68e0063397ba82, COND_EXPR/VEC_COND_EXPR has not
allowed a comparison as the first operand but the gimple front-end
was not updated for this change and you would error out later on.
An assert was added with r15-4791-gb60031e8f9f8fe which meant an ICE
would happen from the gimple FE.
This removes support for parsing of the `?:` expressions except for an
identifier.
Bootstrapped and tested on x86_64-linux-gnu.
gcc/c/ChangeLog:
PR c/117445
* gimple-parser.cc (c_parser_gimple_statement): Remove
support for comparisons before the querry (`?`) token.
Signed-off-by: Andrew Pinski <quic_apin...@quicinc.com>
Diff:
---
gcc/c/gimple-parser.cc | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/gcc/c/gimple-parser.cc b/gcc/c/gimple-parser.cc
index 8d505084a8af..7e445ce2ff8f 100644
--- a/gcc/c/gimple-parser.cc
+++ b/gcc/c/gimple-parser.cc
@@ -880,11 +880,9 @@ c_parser_gimple_statement (gimple_parser &parser,
gimple_seq *seq)
if (lhs.value != error_mark_node
&& rhs.value != error_mark_node)
{
- /* If we parsed a comparison or an identifier and the next token
- is a '?' then parse a conditional expression. */
- if ((COMPARISON_CLASS_P (rhs.value)
- || SSA_VAR_P (rhs.value))
- && c_parser_next_token_is (parser, CPP_QUERY))
+ /* If we parsed an identifier and the next token is a '?' then parse
+ a conditional expression. */
+ if (SSA_VAR_P (rhs.value) && c_parser_next_token_is (parser, CPP_QUERY))
{
struct c_expr trueval, falseval;
c_parser_consume_token (parser);
