https://gcc.gnu.org/g:7383b183e08c7a94fc51d6db89127f7850ef7bc1
commit r17-6114-g7383b183e08c7a94fc51d6db89127f7850ef7bc1 Author: Jeevitha <[email protected]> Date: Tue Nov 10 02:46:24 2026 -0500 rs6000: Improve SFmode splat code generation on Power7/Power8 [PR90824] Use lfiwzx and xxspltw on Power7, and lxsiwzx and xxspltw on Power8, to improve vector splat code generation for SFmode values loaded from memory. This replaces the previous load, conversion and splat sequence. Allow SFmode splat inputs on all VSX targets and use the vsx_splat_v4sf pattern for vector initialization. For register inputs keep the existing conversion and splat sequence. 2026-11-10 Jeevitha Palanisamy <[email protected]> gcc/ PR target/90824 * config/rs6000/predicates.md (splat_input_operand): Allow SFmode with TARGET_VSX instead of TARGET_P9_VECTOR. * config/rs6000/rs6000.cc (rs6000_expand_vector_init): Use vsx_splat_v4sf for all V4SFmode splats. * config/rs6000/vsx.md (vsx_splat_v4sf): Enable for all VSX targets. Add Power7 and Power8 memory-load alternatives. gcc/testsuite/ PR target/90824 * gcc.target/powerpc/pr90824-1.c: New test. * gcc.target/powerpc/pr90824-2.c: New test. Diff: --- gcc/config/rs6000/predicates.md | 2 +- gcc/config/rs6000/rs6000.cc | 24 +++++---------------- gcc/config/rs6000/vsx.md | 31 +++++++++++++++++----------- gcc/testsuite/gcc.target/powerpc/pr90824-1.c | 22 ++++++++++++++++++++ gcc/testsuite/gcc.target/powerpc/pr90824-2.c | 22 ++++++++++++++++++++ 5 files changed, 69 insertions(+), 32 deletions(-) diff --git a/gcc/config/rs6000/predicates.md b/gcc/config/rs6000/predicates.md index 7e028b16a787..03655da5618d 100644 --- a/gcc/config/rs6000/predicates.md +++ b/gcc/config/rs6000/predicates.md @@ -1463,7 +1463,7 @@ vmode = V2DImode; else if (mode == SImode && TARGET_P9_VECTOR) vmode = V4SImode; - else if (mode == SFmode && TARGET_P9_VECTOR) + else if (mode == SFmode && TARGET_VSX) vmode = V4SFmode; else return false; diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index a957a13c2713..9581d122a9d8 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -7032,26 +7032,12 @@ rs6000_expand_vector_init (rtx target, rtx vals) { rtx element0 = XVECEXP (vals, 0, 0); - if (TARGET_P9_VECTOR) - { - if (MEM_P (element0)) - element0 = rs6000_force_indexed_or_indirect_mem (element0); - - emit_insn (gen_vsx_splat_v4sf (target, element0)); - } - + if (MEM_P (element0)) + element0 = rs6000_force_indexed_or_indirect_mem (element0); else - { - rtx freg = gen_reg_rtx (V4SFmode); - rtx sreg = force_reg (SFmode, element0); - rtx cvt = (TARGET_XSCVDPSPN - ? gen_vsx_xscvdpspn_scalar (freg, sreg) - : gen_vsx_xscvdpsp_scalar (freg, sreg)); - - emit_insn (cvt); - emit_insn (gen_vsx_xxspltw_v4sf_direct (target, freg, - const0_rtx)); - } + element0 = force_reg (SFmode, element0); + + emit_insn (gen_vsx_splat_v4sf (target, element0)); } else { diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md index 3a7905df5bae..5c15bcb928c3 100644 --- a/gcc/config/rs6000/vsx.md +++ b/gcc/config/rs6000/vsx.md @@ -4875,24 +4875,31 @@ ;; V4SF splat (ISA 3.0) (define_insn_and_split "vsx_splat_v4sf" - [(set (match_operand:V4SF 0 "vsx_register_operand" "=wa,wa,wa") + [(set (match_operand:V4SF 0 "vsx_register_operand" "=wa,wa,wa,wa,wa") (vec_duplicate:V4SF - (match_operand:SF 1 "splat_input_operand" "Z,wa,r")))] - "TARGET_P9_VECTOR" + (match_operand:SF 1 "splat_input_operand" "Z,Z,Z,wa,r"))) + (clobber (match_scratch:DI 2 "=X,X,d,X,X"))] + "VECTOR_MEM_VSX_P (V4SFmode)" "@ lxvwsx %x0,%y1 + lxsiwzx %x0,%y1\;xxspltw %x0,%x0,1 + lfiwzx %2,%y1\;xxspltw %x0,%x2,1 # mtvsrws %x0,%1" "&& reload_completed && vsx_register_operand (operands[1], SFmode)" - [(set (match_dup 0) - (unspec:V4SF [(match_dup 1)] UNSPEC_VSX_CVDPSPN)) - (set (match_dup 0) - (unspec:V4SF [(match_dup 0) - (const_int 0)] UNSPEC_VSX_XXSPLTW))] - "" - [(set_attr "type" "vecload,vecperm,vecperm") - (set_attr "length" "*,8,*") - (set_attr "isa" "*,p8v,*")]) + [(const_int 0)] +{ + rtx cvt = (TARGET_XSCVDPSPN + ? gen_vsx_xscvdpspn_scalar (operands[0], operands[1]) + : gen_vsx_xscvdpsp_scalar (operands[0], operands[1])); + emit_insn (cvt); + emit_insn (gen_vsx_xxspltw_v4sf_direct (operands[0], operands[0], + const0_rtx)); + DONE; +} + [(set_attr "type" "vecload,vecload,fpload,vecperm,vecperm") + (set_attr "length" "4,8,8,8,4") + (set_attr "isa" "p9v,p8v,*,*,p9v")]) ;; V4SF/V4SI splat from a vector element (define_insn "vsx_xxspltw_<mode>" diff --git a/gcc/testsuite/gcc.target/powerpc/pr90824-1.c b/gcc/testsuite/gcc.target/powerpc/pr90824-1.c new file mode 100644 index 000000000000..3fe7b3bb9762 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr90824-1.c @@ -0,0 +1,22 @@ +/* { dg-do compile } */ +/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O2" } */ +/* { dg-require-effective-target powerpc_vsx } */ + +#include <altivec.h> + +vector float +foo_p (float *a) +{ + return (vector float) { *a, *a, *a, *a }; +} + +vector float +foo_p2 (float *a) +{ + return vec_splats (*a); +} + +/* { dg-final { scan-assembler-times {\mlxsiwzx\M} 2 } } */ +/* { dg-final { scan-assembler-times {\mxxspltw\M} 2 } } */ +/* { dg-final { scan-assembler-not {\mlxsspx\M} } } */ +/* { dg-final { scan-assembler-not {\mxscvdpspn\M} } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/pr90824-2.c b/gcc/testsuite/gcc.target/powerpc/pr90824-2.c new file mode 100644 index 000000000000..096bcd2b4897 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr90824-2.c @@ -0,0 +1,22 @@ +/* { dg-do compile } */ +/* { dg-options "-mdejagnu-cpu=power7 -mvsx -O2" } */ +/* { dg-require-effective-target powerpc_vsx } */ + +#include <altivec.h> + +vector float +foo_p (float *a) +{ + return (vector float) { *a, *a, *a, *a }; +} + +vector float +foo_p2 (float *a) +{ + return vec_splats (*a); +} + +/* { dg-final { scan-assembler-times {\mlfiwzx\M} 2 } } */ +/* { dg-final { scan-assembler-times {\mxxspltw\M} 2 } } */ +/* { dg-final { scan-assembler-not {\mlfs\M} } } */ +/* { dg-final { scan-assembler-not {\mxscvdpsp\M} } } */
