On Wed, Jul 15, 2026 at 08:11:47AM -0500, Manjunath S Matti wrote:
> The changes have been bootstrapped and regression tested on
> powerpc64le-linux.
>
> Register __dmr1024 as a new 1024-bit opaque built-in type, following
> the same pattern as the existing __vector_pair (OOmode) and
> __vector_quad (XOmode) opaque types. __dmr1024 uses TDOmode, which
> was already added in a previous commit ("rs6000: Add TDOmode
> support"), and is intended to hold the contents of a Dense Math
> Register (DMR) when the Dense Math Facility (-mdense-math) is
> enabled.
>
> Note there is no __dmr1024 move pattern (movtdo) yet, so none of
> these tests perform an actual load/store/copy of a __dmr1024 value;
> that is left for a follow-on patch that adds the Dense Math move
> support.
I am uncomfortable adding a type keyword without having some move
patterns. Please reforumulate this patch to either add the basic move
support either combined with this patch or submit the move pattern
first, and then submit this patch after the move support.
In terms of ordering, please submit a patch that adds TDOmode that only
lives in VSX registers. You need to do all of the stuff for allocating
the type (i.e. size/alignment, what type of addressing modes can be
used, spliting move/load/store into vector pair/single registers, and
add reload support etc.).
Then as part of the dense math support, modify the existing allocation,
move, etc. to allow __dm1024 types to go into either VSX registers or
the new dense math registers.
Or possibly wait to add the keyword until the 1,024 bit support is done.
Sorry to come down on this, but I don't like adding a new mode without
having some way to use the mode. I've seen things like this can cause
issues.
--
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: [email protected]
