AMD General Hi
> -----Original Message----- > From: Jiang, Haochen <[email protected]> > Sent: Friday, August 28, 2026 8:41 AM > To: Kumar, Venkataramanan <[email protected]>; gcc- > [email protected] > Cc: Liu, Hongtao <[email protected]>; [email protected]; Sharma, > Dipesh <[email protected]>; Sharma, Dipesh > <[email protected]> > Subject: RE: [PATCH v2 5/7] Support ACEv1 bsr instructions > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > > From: Kumar, Venkataramanan <[email protected]> > > Sent: Thursday, August 27, 2026 8:27 PM > > > > > --- a/gcc/testsuite/lib/target-supports.exp > > > +++ b/gcc/testsuite/lib/target-supports.exp > > > @@ -11741,6 +11741,19 @@ proc check_effective_target_amx_movrs { } > { > > > } "-mamx-movrs" ] > > > } > > > > > > + > > > +# Return 1 if acev1 instructions can be compiled. > > > +proc check_effective_target_acev1 { } { > > > + return [check_no_compiler_messages acev1 object { > > > + void > > > + _bsr0_init () > > > + { > > > + return __builtin_ia32_bsr0init (); > > > + } > > > > I did not understand what this return will do here since it is a void > function. > > I will drop the "return". With this change the patch looks good to me. Regards, Venkat. > > Thx, > Haochen
