On Thu, 28 Aug 2025, Sam James via Gcc wrote: > > Classifications really don't belong in the test name (the thing after > > "PASS: " or "FAIL: ", until end of line) at all, they belong as separate > > metadata so the set of test names can be stable when the testsuite itself > > doesn't change. Unfortunately DejaGnu output doesn't have any clean way > > to provide such metadata for a test result that can be reliably associated > > with it but is clearly separate from the test name. > > This is not to disagree (as I do completely agree, in fact), but does > this have any bearing on the current "internal compiler error" > detection-and-rewriting?
I consider that suspect, precisely because it modifies test names and so means the name of a passing test is not the same as the name of a failing test. Something that fits more cleanly with the concept of test name as the thing after "PASS: " or "FAIL: " would mean that as well as "(test for excess error)" that appears for ever test source file, there would be a similar "(test for internal compiler error)", that normally PASSes, except when there's an ICE in which case it FAILs. (That's still arguably working around limits in the data model for DejaGnu test results, since any test with an ICE should also be failing "test for excess errors" and the ICE is metadata about why "test for excess errors" is failing.) -- Joseph S. Myers josmy...@redhat.com
