Dave Korn <dave.korn.cyg...@gmail.com> writes: > On 30/10/2010 19:24, Richard Henderson wrote: >> On 10/30/2010 11:37 AM, Dave Korn wrote: >>>> Uh, really? I thought there were like a half-dozen lto sections... >>> Which we iterate over just once, and record them all in a hash table from >>> the per-section callback, unless I've missed something. >> >> Oh, right. Nevermind then. >> >> >> r~ > > It'd be worth putting a warning comment on the find_section (no "s") > function saying that it's pretty inefficient and that it is best practice to > call find_sections just once and record details rather than make multiple > calls to find_section. (Both lto FE and lto-plugin are already architected > that way.) > > cheers, > DaveK
I added a sentence "Note that calling this multiple times is inefficient; use objfile_find_sections instead." I added the function because it's what the gccgo frontend needs: it only needs to find one section. Ian
