On Thu, Jan 27, 2011 at 3:46 PM, Diego Novillo <dnovi...@google.com> wrote: > On Thu, Jan 27, 2011 at 05:25, Richard Guenther > <richard.guent...@gmail.com> wrote: > >> Does the tool know when a patch is approved or rejected based on >> review e-mail content? > > I don't think so (the internal version we use does, but I haven't seen > this one implement the same scoring system). An issue is either open > or closed. The original sender can close it once it's been approved. > >> Does it track patches that are related >> somehow (either split patch series or updates to patches after >> these are requested from a reviewer)? > > Yes, a single issue can track multiple versions of the same patch and > patch sets. The tool can show you different views of the patches as > well. > >> And how does this integrate >> with reviewers not using the tool but old-style e-mails? > > If you respond by e-mail (with the subject and CC lines untouched), it > will add the email to the issue trail, just like bugzilla does. > >> >> Thus, is the tool useful to track stalled patches? (does it know when >> a patch is committed and where?) > > Issues will remain visible to you (when you log in) until they are > marked closed by the patch creator. So, yes. I don't think the tool > knows when the patch is committed, though. > > Currently, we are using the standard deployment of Rietveld on > appspot, but if we find this generally useful we could deploy another > instance on sourceware. It should not be hard and I'd volunteer to do > it if there is sufficient interest. I would like to give it a try > first, though.
Sure, as it is non-invasive trying it is ok. I just wanted to see if it fixes any existing problem - it does not seem to (apart from maybe e-mail is so hard, a minor problem compared to programming GCC is so hard ;)) Richard.
