Richard Guenther <richard.guent...@gmail.com> writes: > Sure, as it is non-invasive trying it is ok. I just wanted to see if it > fixes any existing problem - it does not seem to (apart from > maybe e-mail is so hard, a minor problem compared to > programming GCC is so hard ;))
It does fix an existing problem, which is that it is much easier to review a patch in Reitveld than via e-mail (assuming you have a fast Internet connection). You can see as much context as you want in the file, it's easy to comment on specific lines. We use Reitveld for Go patches and it is a huge time saver. In Go we also can commit the exact patch straight from Reitveld; I don't know if the subversion integration supports that. (Go uses Mercurial.) Ian