On Tue, Jul 18, 2017 at 03:52:55PM +0800, Leslie Zhai wrote: > Hi Trevor, > > Thanks for your kind response! > > 在 2017年07月17日 19:51, Trevor Saunders 写道: > > On Wed, Jul 12, 2017 at 10:12:03AM +0800, Leslie Zhai wrote: > > > PS: Trevor's email is not available? thanks! > > Sorry about that, I've left Mozilla and been vacationing for a month, so > > didn't get to updating MAINTAINERS yet. Here's a patch doing that. > Could I use PLUGIN_REGISTER_GGC_ROOTS to take place of > PLUGIN_REGISTER_GGC_CACHES? https://gcc.gnu.org/ml/gcc/2017-07/msg00052.html
If you are ok with your plugin keeping things alive that would otherwise be garbage collected because they are no longer needed sure I think that will work. Though some things are ggc_free()ed and so you might want to be careful touching those things that should be collected but you are keeping alive. Does that help? Trev > > > > > Trev > > > > commit ff900f40d23f765fd59047a90a7e3ff18cbcbf5a > > Author: Trevor Saunders <[email protected]> > > Date: Mon Jul 17 07:44:50 2017 -0400 > > > > update my entry in MAINTAINERS > > ChangeLog: > > * MAINTAINERS: Update my email address. > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index a2f24742374..6a314049c42 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -557,7 +557,7 @@ Hariharan Sandanagobalane > > <[email protected]> > > Iain Sandoe <[email protected]> > > Duncan Sands <[email protected]> > > Sujoy Saraswati > > <[email protected]> > > -Trevor Saunders <[email protected]> > > +Trevor Saunders > > <[email protected]> > > Aaron Sawdey > > <[email protected]> > > Roger Sayle <[email protected]> > > Will Schmidt > > <[email protected]> > > -- > Regards, > Leslie Zhai - a LLVM developer https://reviews.llvm.org/p/xiangzhai/ > > >
