Hello nicolasroard,
I'd like you to do a code review. Please execute
g4 diff -c 10247033
or point your web browser to
http://mondrian/10247033
to review the following code:
Change 10247033 by andr...@andreip-gearslinux on 2009/02/23 18:40:34 *pending*
Fix a rare crash in HTTP request (what else):
- an AsyncTask aborts
- its SafeHttpRequest objects uses a functor to instruct its native
http request object to abort
- the native http request is processing some previous functor and calls
SafeHttpRequest::SetReadyState
- the SafeHttpRequest notices that it's already aborted and calls
Abort() directly on the native http request
- the native http request continues processing the current state and
overwrites the 'aborted' state
- disaster strikes
PRESUBMIT=passed
BUG=1666309
R=nicolasroard
[email protected]
DELTA=22 (18 added, 3 deleted, 1 changed)
OCL=10247033
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#9
edit
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.h#5
edit
22 delta lines: 18 added, 3 deleted, 1 changed
The issue description(s) relevant to this code can be found at:
http://b/issue?id=1666309
Also consider running:
g4 lint -c 10247033
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
