On Wed, 25 Feb 2009 16:15:35 +0100, Steve Block <[email protected]>
wrote:
Thanks for the patch Stig. Other than the few comments below, and some
style
problems, this looks good.
If you can answer the questions below, I'm happy to fix the style
problems and
submit on your behalf.
I have not found a reason for the crashes I experienced, but the same
code has
shown no such behavior on WinMob so I guess it is problems with my
debug build
of Opera.
What do you mean by this exactly? Do you mean that you only saw the
crashes on
desktop Opera?
Yes, only in a debug build with the most recent Opera code on my machine.
Could be something other than the Gears plugin that caused it.
========================================================================
http://mondrian.corp.google.com/file/9185258///depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.cc?a=7
File
//depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.cc
(snapshot 7)
------------------------------------
Line 302: // TODO : assert(url_);
The version of the compiler we use won't accept this. You need
assert(url_.c_str());
========================================================================
http://mondrian.corp.google.com/file/9185258///depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.h?a=7
File
//depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.h
(snapshot 7)
------------------------------------
Line 127: void SetComplete();
I think this is only used by this class, so can be private?
========================================================================
The suggested changes are good. Please put them into the repository.
--
Stig Halvorsen
Senior Core Developer
Opera Software ASA
