looks good, a couple of questions: ======================================================================== http://mondrian.corp.google.com/file/9185258///depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.cc?a=10 File //depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.cc (snapshot 10) ------------------------------------ Line 333: else { move this to the line above ------------------------------------ Line 340: return (long)read; We disallow C casts in C++ code. This should be a static_cast. ------------------------------------ Line 357: url_data_->GetStatusText(&status_line); Hopefully GetStatusText sets status_line to NULL on failure? ------------------------------------ Line 358: if (status_line) { ------------------------------------ Line 360: &response_payload_.status_line); } ------------------------------------ Line 366: &response_payload_.headers); as above ------------------------------------ Line 377: url_data_->GetBodyText(&content, &content_length); again, GetBodyText will set the out params to 0 on failure? ------------------------------------ Line 393: SetComplete(); But...won't we get another call to SetComplete via OnRequestDestroyed()? Wouldn't that Unref() one time too many? ------------------------------------ Line 454: opera_api->RequestUrl(browsing_context_->GetJsContext(), this, this); Just curious: This returns immediately if async_ is true? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9185258
