On Thu, 26 Feb 2009 13:40:13 +0100, Andrei Popescu <[email protected]>
wrote:
looks good, a couple of questions:
========================================================================
http://mondrian.corp.google.com/file/9185258///depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.cc?a=10
File
//depot/googleclient/gears/opensource/gears/localserver/opera/http_request_op.cc
(snapshot 10)
------------------------------------
Line 357: url_data_->GetStatusText(&status_line);
Hopefully GetStatusText sets status_line to NULL on failure?
Yes, it does.
------------------------------------
Line 366: &response_payload_.headers);
as above
If the question is whether the headers returned by GetResponseHeaders()
after a failure is NULL, the answer is yes.
------------------------------------
Line 377: url_data_->GetBodyText(&content, &content_length);
again, GetBodyText will set the out params to 0 on failure?
Yes.
------------------------------------
Line 393: SetComplete();
But...won't we get another call to SetComplete via OnRequestDestroyed()?
Wouldn't that Unref() one time too many?
OnRequestDestroyed() will not be called after
OperaUrlDataInterface::OnComplete() has been called so that will not be a
problem.
------------------------------------
Line 454: opera_api->RequestUrl(browsing_context_->GetJsContext(), this,
this);
Just curious: This returns immediately if async_ is true?
Yes.
--
Stig Halvorsen
Senior Core Developer
Opera Software ASA
