It seems like if anything, this should be getBytes(), and should be asynchronous (what happens if the data backing the blob is on disk?).
Also, Nigel, can you refresh my memory on your use case for appending raw bytes to a BlobBuilder? - a On Sun, Mar 15, 2009 at 9:42 PM, Nigel Tao <[email protected]> wrote: > Hello michaeln, > > I'd like you to do a code review. Please execute > g4 diff -c 10487690 > > or point your web browser to > http://mondrian/10487690 > > to review the following code: > > Change 10487690 by nigel...@nigeltao-srcgears5 on 2009/03/16 15:39:25 > *pending* > > Introduce blob.getByte as a JS-visible method. > > PRESUBMIT=passed > R=michaeln > [email protected] > DELTA=48 (47 added, 0 deleted, 1 changed) > OCL=10487690 > > Affected files ... > > ... //depot/googleclient/gears/opensource/gears/blob/blob.cc #12 edit > ... //depot/googleclient/gears/opensource/gears/blob/blob.h #5 edit > ... > //depot/googleclient/gears/opensource/gears/test/testcases/blob_tests.js #2 > edit > > 48 delta lines: 47 added, 0 deleted, 1 changed > > Also consider running: > g4 lint -c 10487690 > > which verifies that the changelist doesn't introduce new style violations. > > If you can't do the review, please let me know as soon as possible. During > your review, please ensure that all new code has corresponding unit tests > and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or suggestions? > Mail [email protected]. >
