======================================================================== http://mondrian.corp.google.com/file/10487690///depot/googleclient/gears/opensource/gears/blob/blob.cc?a=5 File //depot/googleclient/gears/opensource/gears/blob/blob.cc (snapshot 5) ------------------------------------ Line 91: bool GearsBlob::ReadOffsetAndLengthArgs( On 7:47 am, michaeln wrote: > maybe add a is_offset_required parameter here to have our cake and eat it too? > > blob.slice() // doesn't make much since have this perform a 'clone' > blob.getBytes() // makes lots of sense to return all of the bytes > > i dont feel real strongly about this, just trying to massage things most > sensibly
Done. ------------------------------------ Line 113: return false; On 7:41 am, michaeln wrote: > probably want to context->SetException() here Done. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10487690
