On Thu, Mar 19, 2009 at 04:59, Michael Nordman <[email protected]> wrote: >> Done. This also makes blob.slice() return a blob that's equivalent to the >> original blob, which I suppose is all self-consistent. > > Oh... I see, they use the same helper method... i'm a little wary of > changing the existing semantics of slice() in this way since its > already out there in the wild
It's a change from throwing an exception to not throwing an exception (and instead returning something reasonable), so I don't see it as a backwards incompatible change. Still, my preference is to wind it back one step and make the offset required (but the length optional). Are we agreed on that? >> "this" to be the GearsBlob > > Yes... in the various ports, creating the JSArray and populating it an > element at a time involves many script invocations... sometimes GCs > and or page unloads can happen in there. I see what you're saying. I've added a scoped_refptr<GearsBlob> ref_adder(this).
