======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas.cc?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas.cc (snapshot 1) ------------------------------------ Line 154: // TODO(nigeltao): Should we support BMP? the previous comment was instructive, union it with this new comment. ======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas.h?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas.h (snapshot 1) ------------------------------------ Line 144: nit: empty line ======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc (snapshot 1) ------------------------------------ Line 322: SetPaintColorWithPremultiplication( it's not clear to me what changes in these function calls. please reverse the order of the args, and fix SetPaintColorWithPremultiplication() @378 to match. consider using a "const SkColor color" argument in the method signature @379. ------------------------------------ Line 424: &stroke_style_as_paint_, it'd be nice if we had a style struct to hide all this stroke foo, but since we don't, make these arguments line up as per the google stylee. ------------------------------------ Line 434: SetStyle(context, see comment at @424, same here. ======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h (snapshot 1) ------------------------------------ Line 226: double alpha_as_double_; use global_alpha and global_composite to prefix these 3 variables names, to make it easier to follow wrt to canvas spec. ------------------------------------ Line 230: is there a TODO() to add line width, cap, join, miterLimit state variables? or are those canvas state variables hidden in skia somewhere? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/10747844
