======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas.cc?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas.cc (snapshot 1) ------------------------------------ Line 154: // TODO(nigeltao): Should we support BMP? On 4:18 pm, noel wrote: > the previous comment was instructive, union it with this new comment.
The previous comment is no longer correct -- Skia does indeed support BMP encoding. ======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas.h?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas.h (snapshot 1) ------------------------------------ Line 144: On 4:12 pm, noel wrote: > nit: empty line Done. ======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc (snapshot 1) ------------------------------------ Line 322: SetPaintColorWithPremultiplication( On 4:48 pm, noel wrote: > it's not clear to me what changes in these function calls. please reverse the > order of the args, and fix SetPaintColorWithPremultiplication() @378 to match. > consider using a "const SkColor color" argument in the method signature @379. The order of the args were changed to match the field declarations in the .h file. const added to the SkColor argument to SetPaintColorWithPremultiplication. ------------------------------------ Line 424: &stroke_style_as_paint_, On 5:06 pm, noel wrote: > it'd be nice if we had a style struct to hide all this stroke foo, but since we > don't, make these arguments line up as per the google stylee. Done, although the style guide also says, "Wrapped parameters have a 4 space indent". ======================================================================== http://mondrian.corp.google.com/file/10747844///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h (snapshot 1) ------------------------------------ Line 226: double alpha_as_double_; On 4:29 pm, noel wrote: > use global_alpha and global_composite to prefix these 3 variables names, to make > it easier to follow wrt to canvas spec. Done, although it makes these names longer. ------------------------------------ Line 230: On 4:56 pm, noel wrote: > is there a TODO() to add line width, cap, join, miterLimit state variables? or > are those canvas state variables hidden in skia somewhere? No, these are encapsulated by the SkPaint objects. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10747844
