jonnybot0 commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2164666422
##########
doc/manual/src/docs/asciidoc/080-javascript.adoc:
##########
@@ -32,36 +32,38 @@ This is a bit long winded, and as you would expect Geb uses
the dynamism of Groo
[NOTE]
====
-The `{javascript-executor-api}` interface does not define any contract in
regards to the driver's responsibility when there is some issue executing
JavaScript.
+The `{javascript-executor-api}` interface does not define any contract in
regards to the driver's responsibility when there is some issue executing
JavaScript.
All drivers however throw _some kind_ of exception when this happens.
====
=== Accessing variables
Any _global_ JavaScript variables inside the browser can be read as
_properties_ of the `js` object.
-Given the following page…
+Given the following page...
[source,html]
----
include::{snippets-dir}/javascript/AccessingVariablesSpec.groovy[tag=html,indent=0]
----
-We could access the JavaScript variable “`aVariable`” with…
+We could access the JavaScript variable `aVariable` with...
[source,groovy]
----
include::{snippets-dir}/javascript/AccessingVariablesSpec.groovy[tag=accessing,indent=0]
----
-Or if we wanted to map it to page content…
+Or if we wanted to map it to page content...
[source,groovy]
----
+include::{snippets-dir}/javascript/AccessingVariablesSpec.groovy[tag=mapping_class,indent=0]
Review Comment:
Good catch. Example makes little sense without this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
