Vampire commented on code in PR #277: URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2179415188
########## doc/manual/src/docs/asciidoc/120-build-integrations.adoc: ########## @@ -54,80 +105,67 @@ Below is a valid `pom.xml` file for working with Geb for testing (with Spock). [source,xml,subs="+attributes"] ---- -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> - <groupId>{geb-group}.example</groupId> - <artifactId>geb-maven-example</artifactId> - <packaging>jar</packaging> - <version>1</version> - <name>Geb Maven Example</name> - <url>http://groovy.apache.org/geb/</url> - <dependencies> - <dependency> - <groupId>junit</groupId> - <artifactId>junit</artifactId> - <version>4.8.2</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.spockframework</groupId> - <artifactId>spock-core</artifactId> - <version>{spock-core-version}</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>{geb-group}</groupId> - <artifactId>geb-spock</artifactId> - <version>{geb-version}</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.seleniumhq.selenium</groupId> - <artifactId>selenium-firefox-driver</artifactId> - <version>{selenium-version}</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.seleniumhq.selenium</groupId> - <artifactId>selenium-support</artifactId> - <version>{selenium-version}</version> - <scope>test</scope> - </dependency> - </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-surefire-plugin</artifactId> - <version>2.18.1</version> - <configuration> - <includes> - <include>*Spec.*</include> - </includes> - <systemPropertyVariables> - <geb.build.baseUrl>http://google.com/ncr</geb.build.baseUrl> - <geb.build.reportsDir>target/test-reports/geb</geb.build.reportsDir> - </systemPropertyVariables> - </configuration> - </plugin> - <plugin> - <groupId>org.codehaus.gmaven</groupId> - <artifactId>gmaven-plugin</artifactId> - <version>1.3</version> - <configuration> - <providerSelection>1.7</providerSelection> - </configuration> - <executions> - <execution> - <goals> - <goal>testCompile</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> +<project xmlns="http://maven.apache.org/POM/4.0.0"; Review Comment: As I said, it is not "from days of yore", I found the one place where it is necessary, but still think it should not be added by default and in a minimal example, especially as the error message displayed when it is needed but missing is quite clear: https://github.com/apache/groovy-geb/blob/4aed3b2fe7afbefe0fe1d747f107cd37dd32b3b6/module/geb-core/src/main/groovy/geb/navigator/SelectFactory.groovy#L44-L49 and you might even have it transitively already. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
