Vampire commented on code in PR #277: URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2167641167
########## doc/manual/src/docs/asciidoc/120-build-integrations.adoc: ########## @@ -54,80 +105,67 @@ Below is a valid `pom.xml` file for working with Geb for testing (with Spock). [source,xml,subs="+attributes"] ---- -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> - <groupId>{geb-group}.example</groupId> - <artifactId>geb-maven-example</artifactId> - <packaging>jar</packaging> - <version>1</version> - <name>Geb Maven Example</name> - <url>http://groovy.apache.org/geb/</url> - <dependencies> - <dependency> - <groupId>junit</groupId> - <artifactId>junit</artifactId> - <version>4.8.2</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.spockframework</groupId> - <artifactId>spock-core</artifactId> - <version>{spock-core-version}</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>{geb-group}</groupId> - <artifactId>geb-spock</artifactId> - <version>{geb-version}</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.seleniumhq.selenium</groupId> - <artifactId>selenium-firefox-driver</artifactId> - <version>{selenium-version}</version> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.seleniumhq.selenium</groupId> - <artifactId>selenium-support</artifactId> - <version>{selenium-version}</version> - <scope>test</scope> - </dependency> - </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-surefire-plugin</artifactId> - <version>2.18.1</version> - <configuration> - <includes> - <include>*Spec.*</include> - </includes> - <systemPropertyVariables> - <geb.build.baseUrl>http://google.com/ncr</geb.build.baseUrl> - <geb.build.reportsDir>target/test-reports/geb</geb.build.reportsDir> - </systemPropertyVariables> - </configuration> - </plugin> - <plugin> - <groupId>org.codehaus.gmaven</groupId> - <artifactId>gmaven-plugin</artifactId> - <version>1.3</version> - <configuration> - <providerSelection>1.7</providerSelection> - </configuration> - <executions> - <execution> - <goals> - <goal>testCompile</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> +<project xmlns="http://maven.apache.org/POM/4.0.0"; Review Comment: JUnit => Because this most probably was a left-over from show-casing with Spock 1.x. There Spock was implemented as a custom runner for JUnit 4. With Spock 2.x it is a JUnit 5 Platform Engine and having JUnit 4 as dependency is non-sense, especially if you execute through JUnit Platform and do not also add the Vintage engine that would execute JUnit 4 tests on JUnit Platform. Without it you could write and compile JUnit 4 tests and maybe even execute them in the IDE but the build tool will never execute them. selenium-support => I've not seen where this is ever necessary. And from a cursory look I also did not see which classes one would want to use from it in the own code. I assumed this was necessary in some older versions where something that needed it did not depend on it and so you had to add it yourself. Thus I removed it. Now by looking again, I found what it is necessary for, when using `value` with a `<select>` element. But only exactly then, and if it is missing, then a very meaningful error is shown about adding that dependency if it is missing. So even with that found I would still not add it in the example, but keep the test classpath and example as small as possible and if someone hits that case he is notified to add the dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
